Add extended API to allow rcgen-based tests to be moved to their own crate #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a public API that allows the caller to distinguish the new DoS errors.
This is an intermediate step towards moving them into a separate crate. Leave the `tests` submodule for now, to make the comparison with the old (identical) code easier. The next commit will remove it and re-indent the code.
The tests submodule was a holdover from when these were unit tests.
Remove the `rcgen` dev-dependency from the webpki crate.
Codecov Report
@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 57.48% 57.43% -0.06%
==========================================
Files 20 21 +1
Lines 3599 3597 -2
==========================================
- Hits 2069 2066 -3
- Misses 1530 1531 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove rcgen as a dev-dependency from the webpki crate by moving the rcgen-based tests to their own crate. Revert to testing with the MSRV set to 1.61.0. Take a step towards adding aarch64-pc-windows-msvc to CI.
See each individual commit message for details.