Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break(general): switch from black-list to block-list #3581

Merged
merged 1 commit into from
Sep 29, 2022
Merged

break(general): switch from black-list to block-list #3581

merged 1 commit into from
Sep 29, 2022

Conversation

tsmithv11
Copy link
Collaborator

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Switching from black-list to block-list. I left tests that referenced legitimate uses of whitelist and blacklist.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tsmithv11 tsmithv11 changed the title break: switch from black-list to block-list break(general): switch from black-list to block-list Sep 29, 2022
nimrodkor
nimrodkor approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@nimrodkor nimrodkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

gruebel
gruebel approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥨 🍻

@nimrodkor nimrodkor merged commit f2fae75 into master Sep 29, 2022
@nimrodkor nimrodkor deleted the block-list-name branch September 29, 2022 06:39
Eliran-Turgeman pushed a commit that referenced this pull request Sep 29, 2022
@tsmithv11 @schosterbarak
break(general): switch from black-list to block-list (#3581)
70dec6f 
switch from black-list to block-list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@nimrodkor nimrodkor nimrodkor approved these changes

@eurogig eurogig Awaiting requested review from eurogig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsmithv11 @nimrodkor @gruebel