fix(kubernetes): minor fix for getting entity type from template

[PelegLi]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

avoid exception when extracting entity type from a k8s template

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my feature, policy, or fix is effective and works
• New and existing tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[gruebel]

is it ok, if it is None? not that it results in errors in other areas downstream 😄

[PelegLi]

The only place this method is called from is here, and it means that it would not be able to get checks by entity type and that the results for this unknown entity would be empty

[gruebel]

ok, gotcha. This is more of a type hint concern, but leave it as it is, I will see how it will be, when I add type hints to kubernetes, because get_checks() actually expects a str, which it isn't, but it also doesn't fail, which makes sense from the code.

Suggested change

	kind = entity.get("kind")
	kind = entity.get("kind") or ""

maybe this would be better for downstream handling

[tronxd]

If kind is None then we would not be able to run the K8 check properly since we rely on a non-null value for it. In what use case does it happen?

[PelegLi]

If kind is None then we would not be able to run the K8 check properly since we rely on a non-null value for it. In what use case does it happen?

Maybe a malformed template. If we cannot infer the entity type then we can't get the relevant checks

[gruebel]

☕