Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): Fix related_resource_id for ImageReferencer in external_module #3780

Merged
merged 6 commits into from
Nov 2, 2022
Merged

fix(terraform): Fix related_resource_id for ImageReferencer in external_module #3780

merged 6 commits into from
Nov 2, 2022

Conversation

ChanochShayner
Copy link
Contributor

@ChanochShayner ChanochShayner commented Oct 31, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fixed an issue where the related_resource_id in images for Image Referencer was wrong for external_modules.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

YaaraVerner
YaaraVerner approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@YaaraVerner YaaraVerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑

@ChanochShayner ChanochShayner merged commit 75be952 into master Nov 2, 2022
@ChanochShayner ChanochShayner deleted the fix-relatedResourceId-ExternalModule branch November 2, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaaraVerner YaaraVerner YaaraVerner approved these changes

@achiar99 achiar99 achiar99 approved these changes

@tronxd tronxd tronxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChanochShayner @tronxd @achiar99 @YaaraVerner