platform(sca): Run package scan using API #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # checkov/sca_package_2/runner.py # checkov/sca_package_2/scanner.py
gruebel
reviewed
Nov 8, 2022
checkov/sca_package_2/scanner.py
Outdated
| } | ||
|
|
||
| response = request_wrapper( | ||
| "POST", f"{self._base_url}/api/v1/vulnerabilities/cli/scan", |
There was a problem hiding this comment.
can you move f"{self._base_url}/api/v1/vulnerabilities/cli/scan" to the __init__ then it can be used for the polling to0.
checkov/sca_package_2/scanner.py
Outdated
| logging.info("Failed to run package scanning.") | ||
| return dict() | ||
|
|
||
| return self.poll_scan_result() |
There was a problem hiding this comment.
I think the polling should be under def scan(), just return the id here so, it can be used by poll_scan_result()
AdamDev
approved these changes
Nov 8, 2022
NoaAzoulay
approved these changes
Nov 8, 2022
kadoshms
pushed a commit
that referenced
this pull request
Nov 8, 2022
* add new sca package * updated * updated * removed redundant lines * update class * run sca scan * mypy * flake8 * RUN_SCA_PACKAGE_SCAN_V2 * RUN_SCA_PACKAGE_SCAN_V2 * fixed * reformat path * fix files config * updated * mypy * fixed root_folder * Added tests * update files * mypy * linting * Fixed tests * Fixed tests * Fixed tests * update endpoint url * updated * linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
using POST request start sca package scanning process
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: