Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): Not adding dynamic blocks attributes to attributes #3872

Merged
merged 10 commits into from
Nov 15, 2022
Merged

fix(terraform): Not adding dynamic blocks attributes to attributes #3872

merged 10 commits into from
Nov 15, 2022

Conversation

ChanochShayner
Copy link
Contributor

@ChanochShayner ChanochShayner commented Nov 14, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • Not adding dynamic block attributes to attributes.
  • Adding 2 UTs examples that actually fail on policies.
  • Skipping failing UT for a nested block with a nested object.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ChanochShayner ChanochShayner merged commit 7637bd1 into master Nov 15, 2022
@ChanochShayner ChanochShayner deleted the fix-dynamic-attributes-override-each-other-2 branch November 15, 2022 06:56
ayajbara pushed a commit that referenced this pull request Nov 15, 2022
@ChanochShayner @actions-user
fix(terraform): Not adding dynamic blocks attributes to attributes (#…
898ca02 
…3872)

* Not adding dynamic attributes to attributes

* Add dynamic_attributes to TerraformBlock

* Add to_list

* Add arg for dynamic

* Add arg for dynamic

* Add UT

* Fix UT

* Adding UTs

* Skipping nested UT for now.
ayajbara pushed a commit that referenced this pull request Nov 15, 2022
@ChanochShayner @actions-user
fix(terraform): Not adding dynamic blocks attributes to attributes (#…
b54d811 
…3872)

* Not adding dynamic attributes to attributes

* Add dynamic_attributes to TerraformBlock

* Add to_list

* Add arg for dynamic

* Add arg for dynamic

* Add UT

* Fix UT

* Adding UTs

* Skipping nested UT for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achiar99 achiar99 achiar99 approved these changes

@PelegLi PelegLi PelegLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChanochShayner @PelegLi @achiar99