Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kubernetes): Add CKV2_K8S_3 no impersonate permissions for ServiceAccount/Node #4037

Merged
merged 4 commits into from
Dec 11, 2022
Merged

feat(kubernetes): Add CKV2_K8S_3 no impersonate permissions for ServiceAccount/Node #4037

merged 4 commits into from
Dec 11, 2022

Conversation

bo156
Copy link
Contributor

@bo156 bo156 commented Dec 11, 2022 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Add CKV2_K8S_3 no impersonate permissions for ServiceAccount/Node on users/groups/service-accounts

New/Edited policies

  • Add CKV2_K8S_3 no impersonate permissions for ServiceAccount/Node

Fix

Remove impersonate permissions from the relevant Role/ClusterRole

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

gruebel
gruebel approved these changes Dec 11, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄

@bo156 bo156 merged commit 2acdb9e into main Dec 11, 2022
@bo156 bo156 deleted the feature/k8s-graph-check-no-impersonate-permissions branch December 11, 2022 10:08
ayajbara pushed a commit that referenced this pull request Dec 11, 2022
@bo156 @actions-user
feat(kubernetes): Add CKV2_K8S_3 no impersonate permissions for `Se…
1f26d3f 
…rviceAccount/Node` (#4037)

* Added basic tests that should fail

* Added yaml check for impersonate permissions

* Added a passing test and fixed yaml lists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaaraVerner YaaraVerner YaaraVerner approved these changes

@gruebel gruebel gruebel approved these changes

@tronxd tronxd tronxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bo156 @tronxd @gruebel @YaaraVerner