Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secrets): expose maximum 6 characters of secret values #4140

Merged
merged 6 commits into from
Dec 22, 2022
Merged

feat(secrets): expose maximum 6 characters of secret values #4140

merged 6 commits into from
Dec 22, 2022

Conversation

arielkru
Copy link
Collaborator

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

gruebel
gruebel approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄

@arielkru arielkru merged commit b4bf19c into main Dec 22, 2022
@arielkru arielkru deleted the set_max_chars_to_expose branch December 22, 2022 17:04
Teko012 pushed a commit to Teko012/checkov_fork_bridgecrewio that referenced this pull request Dec 22, 2022
@arielkru @achiar99 @actions-user
feat(secrets): expose maximum 6 characters of secret values (bridgecr…
840e8ee 
…ewio#4140)

* conflict

* Revert "conflict"

This reverts commit ced5447.

* expose max 6 chars

* if bigger than 100 is redunandt

* update tests

Co-authored-by: achia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marynaKK marynaKK marynaKK approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arielkru @gruebel @marynaKK @achiar99