Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): remove redundant nested definitions #4147

Merged
merged 9 commits into from
Dec 26, 2022

Conversation

achiar99
Copy link
Contributor

@achiar99 achiar99 commented Dec 25, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

when we scan a folder with main.tf (module number 2) and it call to third/main.tf (module number 3) that call to four/main.tf (module number 4)
and we also have a module that use module 2 (this is module 1) in examples/main.tf

  -> 3 -> 4
2
  <- 1

we want to have these definitions:
1
1->2
1->2->3
1->2->3->4

and not:
2
2->3
2->3->4
3
3->4
4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

checkov/terraform/parser.py Outdated Show resolved Hide resolved
checkov/terraform/parser.py Outdated Show resolved Hide resolved
@achiar99 achiar99 merged commit 9e8522e into main Dec 26, 2022
@achiar99 achiar99 deleted the remove-redundant-definitions branch December 26, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants