Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): default value for CKV_AZURE_5 #4237

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

fredgate
Copy link
Contributor

@fredgate fredgate commented Jan 11, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

The check CKV_AZURE_5 should succeed if the role_based_access_control_enabled property is not set in resource azurerm_kubernetes_cluster as its default value is true.

Fixes #4227

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@fredgate fredgate force-pushed the fix/ckv_azure_5-default-value branch 2 times, most recently from 2ac7cfb to b637df0 Compare January 11, 2023 23:30
@fredgate fredgate force-pushed the fix/ckv_azure_5-default-value branch from 8f98f5b to 7a40673 Compare January 13, 2023 10:35
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🍻

@gruebel gruebel merged commit 686a8f9 into bridgecrewio:main Jan 16, 2023
praveen-panw pushed a commit to praveen-panw/bc_checkov that referenced this pull request Jan 16, 2023
@fredgate fredgate deleted the fix/ckv_azure_5-default-value branch January 16, 2023 15:49
reemodo pushed a commit to reemodo/checkov that referenced this pull request Jan 22, 2023
reemodo pushed a commit to reemodo/checkov that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for check CKV_AZURE_5: "Ensure RBAC is enabled on AKS clusters"
3 participants