Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(general): fix circleci yaml-doc #4246

Merged
merged 3 commits into from
Jan 15, 2023
Merged

feat(general): fix circleci yaml-doc #4246

merged 3 commits into from
Jan 15, 2023

Conversation

maxamel
Copy link
Contributor

@maxamel maxamel commented Jan 15, 2023 •
edited
Loading

This PR fixes case of mismatched type in yaml-doc for resolving sub name in workflow content.
Also a resource test file is added to vcs scanning.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@maxamel maxamel changed the title feat(general): fix circleci ysml-doc feat(general): fix circleci yaml-doc Jan 15, 2023
@maxamel maxamel marked this pull request as ready for review January 15, 2023 09:22
marynaKK
marynaKK reviewed Jan 15, 2023
View reviewed changes
tests/github/resources/github_conf/empty_collabs/repository_collaborators.json
@@ -0,0 +1 @@
[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a test for it, but I guess the resource test file was left out

marynaKK
marynaKK reviewed Jan 15, 2023
View reviewed changes
Copy link
Contributor

@marynaKK marynaKK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also might want to add a test for it:

jobs:
    build_job:
      steps:
        - checkout

After debugging this is not the error, but this:

jobs:
    test-job-single-line: run/script

commenting just for documentation :)

@maxamel maxamel merged commit 82f74fd into main Jan 15, 2023
@maxamel maxamel deleted the fix-error-yaml-doc branch January 15, 2023 11:46
reemodo pushed a commit to reemodo/checkov that referenced this pull request Jan 22, 2023
@maxamel
feat(general): fix circleci yaml-doc (bridgecrewio#4246)
e89ddcb 
* fix circleci ysml-doc

* add test snippet to workflows file

* add single line test

Co-authored-by: Max Amelchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marynaKK marynaKK marynaKK approved these changes

@Eliran-Turgeman Eliran-Turgeman Eliran-Turgeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxamel @Eliran-Turgeman @marynaKK