fix(general): Enable running cloned policies in case the OOTB policy is suppressed #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo156
requested changes
Jan 19, 2023
| bc_cloned_checks = custom_policies_integration.bc_cloned_checks | ||
| runner_filter.bc_cloned_checks = bc_cloned_checks | ||
| custom_policies_integration.policy_level_suppression = policy_level_suppression | ||
| runner_filter.set_suppressed_policies(policy_level_suppression) |
There was a problem hiding this comment.
looks like you have this block of code 3 times here, can you extract to a function?
There was a problem hiding this comment.
Not needed IMO (we won't reuse it anywhere else than main)
gruebel
reviewed
Jan 19, 2023
checkov/common/bridgecrew/integration_features/features/suppressions_integration.py
Outdated
Show resolved
Hide resolved
… cloned_suppressed_policies
bo156
approved these changes
Jan 19, 2023
reemodo
pushed a commit
to reemodo/checkov
that referenced
this pull request
Jan 22, 2023
…is suppressed (bridgecrewio#4281) * enable running cloned policies in case the OOTB policy is suppressed * flake8 lint * mypy * UT * lint * lint * UT * PR comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Handle cases where cloned policies are not ran in case their OOTB policy is suppressed
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: