Json importer #139
Open
Json importer #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentification of processes.
tngTUDOR
reviewed
Sep 30, 2022
README.rst
Outdated
| @@ -1,3 +1,6 @@ | |||
| This is a fork of the original brightway2-io. My intention is to be able to import USLCI database using the JSON-LD importer. | |||
There was a problem hiding this comment.
Please revert this one for the PR.
tngTUDOR
reviewed
Sep 30, 2022
| @@ -132,7 +132,7 @@ def boolcheck(lst): | |||
| { | |||
| "code": obj["@id"], | |||
| "name": obj["name"], | |||
| "categories": category_mapping[obj["category"]["@id"]], | |||
| "categories": category_mapping[obj["category"]["@id"]], #There is no 'category'... does he mean 'type'? | |||
There was a problem hiding this comment.
What does the olca-schema say about this ?
|
This is an amazing contribution, but also quite big. I don't feel comfortable reviewing or merging this without some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for OpenLCA USLCI importing