Return error when casting empty string to duration

Closes #4962
brimdata · Jan 4, 2024 · 2870013 · 2870013
1 parent 98d319d
commit 2870013
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/pkg/nano/duration.go b/pkg/nano/duration.go
@@ -140,7 +140,7 @@ var scale = map[string]Duration{
 
 func ParseDuration(s string) (Duration, error) {
 	if len(s) == 0 {
-		return 0, nil
+		return 0, fmt.Errorf("invalid duration: %q", s)
 	}
 	var negative bool
 	if s[0] == '-' {

diff --git a/runtime/expr/ztests/cast-dur-empty-string.yaml b/runtime/expr/ztests/cast-dur-empty-string.yaml
@@ -0,0 +1,6 @@
+zed: 'yield duration(this)'
+
+input: '""'
+
+output: |
+  error({message:"cannot cast to duration",on:""})