Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grok: Fix panic when encountering optional fields #5010

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

mattnibs
Copy link
Collaborator

Closes #5008

@mattnibs mattnibs requested a review from a team January 26, 2024 18:53
@mattnibs mattnibs force-pushed the grok-optional-fields branch 2 times, most recently from 1cc6185 to ade4788 Compare January 26, 2024 18:56
@philrz
Copy link
Contributor

philrz commented Jan 26, 2024

Just tested out this branch at commit 9c4d65f and indeed it fixes the panics for both the repro cases shown in #5008 so it's a functional 👍 for me!

@mattnibs mattnibs merged commit f50db2d into main Jan 27, 2024
3 checks passed
@mattnibs mattnibs deleted the grok-optional-fields branch January 27, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grok() panics on "a|b" pattern when both a and b contain named grok patterns
3 participants