Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rust library filename on Windows #3

Merged
merged 4 commits into from
Jan 15, 2021
Merged

Fix Rust library filename on Windows #3

merged 4 commits into from
Jan 15, 2021

Commits on Jan 14, 2021

  1. Use default RUST_SURICATA_LIBNAME

    @philrz
    philrz committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    d0cfc20 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Revert "Use default RUST_SURICATA_LIBNAME" 

    This reverts commit d0cfc20.
    @philrz
    philrz committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    6f3b07d View commit details
    Browse the repository at this point in the history

  2. configure/mingw: move libs in LDFLAGS to LDADD 

    Moving the libs specified in LDFLAGS to LDADD put them into the
correct placement on in the link command.

(cherry picked from commit 10f639e)
    @jasonish @philrz
    jasonish authored and philrz committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    22035ef View commit details
    Browse the repository at this point in the history

  3. rust: handle windows naming change from .lib to .a 

    Prior to Rust 1.44, Cargo would name static libs with the .lib
extension. 1.44 changes this extension to .a when running under
a GNU environment on Windows like msys to make it more similar
to other unix environments.

Now assume static library name to be the same on Windows and
unix, but rename the .lib if found to still support older
versions of Rust on Windows.

(cherry picked from commit f3c59ef)
    @jasonish @philrz
    jasonish authored and philrz committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    7603e1e View commit details
    Browse the repository at this point in the history