Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify a directory for extracted pcap flows #1423

Closed
philrz opened this issue Feb 4, 2021 · 2 comments · Fixed by #3053
Closed

Allow user to specify a directory for extracted pcap flows #1423

philrz opened this issue Feb 4, 2021 · 2 comments · Fixed by #3053

Comments

@philrz
Copy link
Contributor

philrz commented Feb 4, 2021

Right now when the user clicks the Packets button, the flow extracted from the larger pcap gets stored in a file in a tmpdir before being opened in whatever app the OS has tied to that file type. In a group discussion on 2021-02-02, we recognized that it might be helpful to allow the user to specify a specific, non-tmpdir folder. A use case that might be enabled by this would be the saving of several separate extractions to the same folder, such as if data is being accumulated as part of an investigation. This might make sense as an option in the Preferences menu, or perhaps something that could be specified via right-click on the Packets button, possibly with memory of recent folder choices to make it easy for the user to keep adding to a particular location.

@philrz
Copy link
Contributor Author

philrz commented Aug 16, 2022

It looks like the path to the tmpdir is obtained here:

https://github.com/brimdata/brim/blob/1ee21a85330f62430d65298f61939e95469dd1a5/src/plugins/brimcap/brimcap-plugin.ts#L225

Therefore once the setting is added to Preferences this would be the spot to make use of it.

@philrz
Copy link
Contributor Author

philrz commented Apr 23, 2024

Verified in Zui commit 2d23f20.

As shown in the attached video, by default pcap slices are still stored in $TMPDIR. However, a new setting is now available in Settings > Packet Captures > Folder For Extracted pcaps that allows the selection of an alternate location. When this setting is populated, pcap slices are stored there instead. If the setting is cleared, they once again are stored in $TMPDIR.

Verify.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant