Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Setting for folder to store extracted pcap slices #3053

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Apr 20, 2024

As described in #1423, we've recognized that a user might find it useful to specify a specific directory to hold extracted pcap slices, e.g., if they're gathering them up as part of an investigation. The changes in #3049 made me realize how easy it would be to add this as a Setting, so that's what I've done here.

The attached video shows the feature working as intended using the branch from this PR at commit 651e403. As a baseline I show the default app behavior of extracting to $TMPDIR. Then I apply the new setting and show the pcap going to the selected directory. Then I clear out the setting and show the pcaps going back to $TMPDIR again.

Demo.mp4

Closes #1423

@philrz philrz requested a review from jameskerr April 20, 2024 18:29
@philrz philrz self-assigned this Apr 20, 2024
Copy link
Member

@jameskerr jameskerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah!

@philrz philrz merged commit ef047c6 into main Apr 23, 2024
3 checks passed
@philrz philrz deleted the pcap-directory-setting branch April 23, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to specify a directory for extracted pcap flows
2 participants