Install whois in CI so right-click test can succeed #2963
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
right-click-menus.spec.ts
e2e test set that was added as part of #2895 has failed 100% of the time in CI due to a problem with thewho is
test case. A recent example failure from this run:Despite the scary "Application exited" wording, closer inspection reveals a simple explanation: The right-click Whois lookup in Zui still relies on a
whois
executable being present (see #1052). This PR just adds the executable to the Actions Runners where needed. The run https://github.com/brimdata/zui/actions/runs/7493437314/job/20399136004 on this branch shows the test now passing on all three OSes.