Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install whois in CI so right-click test can succeed #2963

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Jan 11, 2024

The new right-click-menus.spec.ts e2e test set that was added as part of #2895 has failed 100% of the time in CI due to a problem with the who is test case. A recent example failure from this run:

2) right-click-menus.spec.ts:56:3 › right-click-menus › who is ───────────────────────────────────
    Test timeout of 30000ms exceeded.
    Error: locator.click: Application exited
    Call log:
      - waiting for getByRole('button', { name: 'Done', exact: true }).first()
      -   locator resolved to <button type="button">Done</button>
      - attempting click action
      -   waiting for element to be visible, enabled and stable
      -     element is not stable - waiting...
      - element was detached from the DOM, retrying
       at ../helpers/test-app.ts:162
      160 |
      161 |   async click(role: Role | RegExp, name?: string) {
    > 162 |     return this.locate(role, name).click();
          |                                    ^
      163 |   }
      164 |
      165 |   async rightClick(role: Role | RegExp, name?: string) {
        at TestApp.click (/home/runner/work/zui/zui/packages/zui-player/helpers/test-app.ts:162:[36](https://github.com/brimdata/zui/actions/runs/7492874104/job/20397350722#step:8:37))
        at /home/runner/work/zui/zui/packages/zui-player/tests/right-click-menus.spec.ts:63:15

Despite the scary "Application exited" wording, closer inspection reveals a simple explanation: The right-click Whois lookup in Zui still relies on a whois executable being present (see #1052). This PR just adds the executable to the Actions Runners where needed. The run https://github.com/brimdata/zui/actions/runs/7493437314/job/20399136004 on this branch shows the test now passing on all three OSes.

@philrz philrz requested a review from jameskerr January 11, 2024 19:31
@philrz philrz self-assigned this Jan 11, 2024
@philrz philrz merged commit 78ebf38 into main Jan 11, 2024
6 checks passed
@philrz philrz deleted the fix-right-click-whois-test branch January 11, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants