Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We were not catching the abort error properly when issuing a query before the previous query finished.
We also were not aborting all of the histogram queries when re-issuing a search.
This stuff is really hard to write tests for. There are no tests in this PR. 🤷♂️
To test this, re-issue the search with a large pool over and over again rapidly. Open the network tab and view all the in-flight requests properly cancelling when a new search is issued.
Fixes #2997
Fixes #2999
Fixes #2838