Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zed lake service should listen only on localhost by default #3091

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Jun 11, 2024

Fixes #3056, which has lots of background.

Now that the changes in #3069 have brought us to the the "use Electron's net.fetch()" state foretold in #3056 (comment), here I'm restoring the prior behavior where the Zed service launched by Zui listens only on localhost:9867 and therefore will no longer be open to connections from remote hosts.

$ ps auxww | grep -i zed
phil             52388   0.0  0.1 35563004  21380 s000  S+    6:17PM   0:00.05 /Users/phil/work/zui/apps/zui/zdeps/zed serve -l localhost:9867 -lake /Users/phil/work/zui/apps/zui/run/lake -manage=5m -log.level=info -log.filemode=rotate -log.path /Users/phil/work/zui/apps/zui/run/logs/zlake.log --cors.origin=* -brimfd=3

At some point after this merges, I'll introduce something in Settings so a user could open this back up if that's actually their preference (#1105).

@philrz philrz requested a review from jameskerr June 11, 2024 01:23
@philrz philrz self-assigned this Jun 11, 2024
@philrz philrz merged commit 9c37575 into main Jun 12, 2024
4 checks passed
@philrz philrz deleted the lake-service-localhost-only branch June 12, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zed lake service launched by Zui is accepting remote connections
2 participants