Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Registered screenshot Extension" is too annoying #9

Merged
merged 1 commit into from
Aug 7, 2020
Merged

"Registered screenshot Extension" is too annoying #9

merged 1 commit into from
Aug 7, 2020

Conversation

aglitchman
Copy link
Contributor

No description provided.

Copy link
Owner

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agreed!

@britzl britzl merged commit 9424c01 into britzl:master Aug 7, 2020
@subsoap
Copy link

subsoap commented Aug 7, 2020

I don't have a problem with these personally, but if the Registered messages are going to be removed from one they should be removed from all.

Registered only, not Initialized though, I want to see when things init (like in the case of Steamworks, Steamworks itself initializing is different from the extension initialization).

INFO:DLIB: Log server started on port 51921
INFO:ENGINE: Engine service started on port 51922
INFO:ENGINE: Defold Engine 1.2.171 (29b8e59)
INFO:OpenSSL: AppInitializeExtension
INFO:ENGINE: Loading data from: build/default
INFO:OpenSSL: Registered openssl Lua extension

INFO:OpenSSL: OpenSSL fully initialized!
INFO:DISCORDRICH: Running in the editor. Will attempt to load libraries from project
INFO:LFS: Registered lfs Extension

INFO:STEAMWORKS: Registered steamworks Extension
INFO:ENGINE: Initialised sound device 'default'

WARNING:DLIB: Profiler Resource.Get took 2.174 seconds
WARNING:DLIB: Profiler Resource.Get took 6.128 seconds
INFO:STEAMWORKS: Init

@aglitchman
Copy link
Contributor Author

Registered only, not Initialized though, I want to see when things init (like in the case of Steamworks, Steamworks itself initializing is different from the extension initialization).

Good point. Personally, I like to see "initialization" messages, too.

But "registered" messages are useless, they bloat our logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants