-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WX-757 Fix workflow stuck in aborting after WDL type error #7385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgainerdewar
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent sleuthing!
Adding on to this PR... a third (!) variant that is more recent (Slack link) and ended up being an array issue. I think we understand the pattern at this point so not adding a Centaur test for every single WOM type.
|
THWiseman
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was caused by "userland" (WDL) code throwing an exception where we did not expect it, causing issues for the "kernel" (Cromwell).
Now we encapsulate possible exceptions in an
ErrorOr
so they can be safely evaluated in thecase Left(f) =>
. As a stylistic point, I changedWomMap()
toWomMap.apply()
to make it more obvious that we're really doing a lot of custom stuff and it's not just a regular old constructor.As a bonus, the new code detects all previous stuck-aborting workflows and fails them.
After:
Before: