[WX-1605] Fix Codecov Report Uploads #7418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsaperst
approved these changes
May 2, 2024
aednichols
approved these changes
May 2, 2024
aednichols
reviewed
May 2, 2024
| - uses: codecov/codecov-action@v4 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| fail_ci_if_error: true # Tolerate missing codecov reports, since not all suites generate them. |
There was a problem hiding this comment.
I think we want false here, the no-coverage suites are failing.
There was a problem hiding this comment.
Trying to figure out if there's a way to fail loudly if the upload fails, but also tolerate missing code-coverage for certain suites. The handle_no_reports_found flag does not work!
There was a problem hiding this comment.
Giving up on this for now. Will just leave fail_ci_if_error as false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old way of uploading coverage repots to CodeCov has broken. Using this github action is now the preferred method.
This branch also required adding a secret to this repository. I got the token from the codecov settings page.