Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for no decimal point in float INFO fields #5789

Closed
pontikos opened this issue Mar 12, 2019 · 8 comments
Closed

allow for no decimal point in float INFO fields #5789

pontikos opened this issue Mar 12, 2019 · 8 comments

Comments

@pontikos
Copy link

bcftools removes decimal point when there are trailing zeroes:
samtools/bcftools#980

GATK should be able to handle floating points without a decimal point.

@lbergelson
Copy link
Member

Is this specifically a problem filtering VCF's with filter expressions written in jexl? Or are you hitting it somewhere else as well?

@pontikos
Copy link
Author

pontikos commented Mar 12, 2019 via email

@lbergelson
Copy link
Member

Any chance you could test with GATK 4.1.0.0 to make sure it's still happening? GATK 3.5 is no longer maintained.

@pontikos
Copy link
Author

Sorry but I am stuck with using GATK 3.5 at the moment as they are too many difference between GATK 4 and GATK 3.

@lbergelson
Copy link
Member

Ok. I'm sorry, but we're unable to help you then. GATK 3 is no longer maintained or updated. We recommend everyone upgrades to 4. The differences between 3 and 4 are only going to increase over time.

Is there a specific missing feature preventing you from upgrading? Or some issue that manifests in 4 but not 3?

@ldgauthier
Copy link
Contributor

@pontikos if you use the issue template we might be able to help.

Affected tool(s) or class(es)

Tool/class name(s), special parameters?

Affected version(s)

  • Latest public release version [version?]
  • Latest master branch as of [date of test?]

Steps to reproduce

Tell us how to reproduce this issue. If possible, include command lines that reproduce the problem. (The support team may follow up to ask you to upload data to reproduce the issue.)

@lbergelson
Copy link
Member

Closing since the bug was reported against GATK 3.

@cmnbroad
Copy link
Collaborator

cmnbroad commented May 22, 2019

FWIW, this issue was fixed in GATK 4 a while back. It sounds exactly like #4633, which was fixed in #4680.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants