setting default compression level to 2 #4547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbergelson
force-pushed
the
lb_set_default_compression_to_2
branch
from
4a25185
to
9e32dcb
Compare
|
@jonn-smith I forgot to change the default in the GATKConfig.java, and your test caught it. That's awesome! |
Codecov Report
@@ Coverage Diff @@
## master #4547 +/- ##
===============================================
+ Coverage 79.721% 79.724% +0.003%
Complexity 16812 16812
===============================================
Files 1054 1054
Lines 60485 60485
Branches 9905 9905
===============================================
+ Hits 48219 48221 +2
+ Misses 8401 8399 -2
Partials 3865 3865
|
droazen
approved these changes
Mar 21, 2018
cwhelan
pushed a commit
to cwhelan/gatk-linked-reads
that referenced
this pull request
May 25, 2018
changing the default compression level 1 -> 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm honestly not sure which of the various settings take precedence, so I set them all... We should remove the irrelevant ones. I assume that that includes the ones in the
gatklaunch script as well as the defaults in build.gradle?