Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qual = 0 sites don't count as polymorphic for GVCF mode #4967

Merged
merged 3 commits into from
Jul 3, 2018

Conversation

davidbenjamin
Copy link
Contributor

@ldgauthier This is for #4614.

@codecov-io
Copy link

Codecov Report

Merging #4967 into master will increase coverage by 0.005%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #4967       +/-   ##
===============================================
+ Coverage     80.789%   80.793%   +0.005%     
- Complexity     17945     17947        +2     
===============================================
  Files           1094      1094               
  Lines          64524     64524               
  Branches       10392     10392               
===============================================
+ Hits           52128     52131        +3     
+ Misses          8374      8371        -3     
  Partials        4022      4022
Impacted Files Coverage Δ Complexity Δ
.../walkers/genotyper/afcalc/AFCalculationResult.java 67.164% <100%> (ø) 20 <0> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 80% <0%> (+30%) 3% <0%> (+2%) ⬆️

Copy link
Contributor

@ldgauthier ldgauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Thanks for the explanation in the comments. When do you want to change -stand-call-conf in GenotypeCalculationArgumentCollection? It will probably break a bunch of tests, but you could also change the test commands to set it back to 10.

@davidbenjamin
Copy link
Contributor Author

I was assuming I would change the default in the same PR that makes new qual default.

@ldgauthier
Copy link
Contributor

Fair point. I'll try to help remember.

@davidbenjamin
Copy link
Contributor Author

Is this PR good to merge then?

@ldgauthier
Copy link
Contributor

👍

@davidbenjamin davidbenjamin merged commit ddf042a into master Jul 3, 2018
@davidbenjamin davidbenjamin deleted the db_qual_epsilon branch July 3, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants