Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the file handles issue discussed in #5066 #5105

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Fix the file handles issue discussed in #5066 #5105

merged 1 commit into from
Aug 14, 2018

Conversation

kgururaj
Copy link
Collaborator

Some speedup by eliminating a ls operation - however, having 10K small arrays will still be slower than 100 large arrays.

* Some speedup by eliminating a ls operation
@kgururaj kgururaj requested a review from cmnbroad August 14, 2018 16:25
@codecov-io
Copy link

Codecov Report

Merging #5105 into master will increase coverage by 1.151%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #5105       +/-   ##
===============================================
+ Coverage     85.341%   86.492%   +1.151%     
- Complexity     28712     29204      +492     
===============================================
  Files           1814      1814               
  Lines         135364    135364               
  Branches       15042     15042               
===============================================
+ Hits          115521    117079     +1558     
+ Misses         14309     12825     -1484     
+ Partials        5534      5460       -74
Impacted Files Coverage Δ Complexity Δ
...utils/smithwaterman/SmithWatermanIntelAligner.java 50% <0%> (-30%) 1% <0%> (-2%)
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 60% <0%> (ø) 2% <0%> (ø) ⬇️
...nstitute/hellbender/utils/read/AlignmentUtils.java 75.605% <0%> (+0.202%) 149% <0%> (+1%) ⬆️
...ools/walkers/haplotypecaller/graphs/BaseGraph.java 82.239% <0%> (+0.386%) 94% <0%> (+1%) ⬆️
...roadinstitute/hellbender/utils/read/ReadUtils.java 80.653% <0%> (+0.466%) 209% <0%> (ø) ⬇️
...kers/variantutils/PosteriorProbabilitiesUtils.java 81.41% <0%> (+0.641%) 50% <0%> (ø) ⬇️
...nder/utils/runtime/StreamingProcessController.java 72.249% <0%> (+0.957%) 36% <0%> (+1%) ⬆️
...annotator/allelespecific/AS_RMSMappingQuality.java 88.35% <0%> (+0.971%) 34% <0%> (ø) ⬇️
.../utils/smithwaterman/SmithWatermanJavaAligner.java 94.118% <0%> (+1.176%) 46% <0%> (ø) ⬇️
...ols/walkers/haplotypecaller/AssemblyResultSet.java 75.449% <0%> (+1.198%) 44% <0%> (+1%) ⬆️
... and 49 more

@droazen droazen self-requested a review August 14, 2018 17:36
@droazen droazen self-assigned this Aug 14, 2018
Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@droazen droazen merged commit 6e44c60 into master Aug 14, 2018
@droazen droazen deleted the refine-5066 branch August 14, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants