-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix asynchronous Python exception propagation in StreamingPythonExecutor/CNNScoreVariants. #7402
Conversation
38a1180
to
9612fa1
Compare
9612fa1
to
7a15b2f
Compare
@cmnbroad Is this still a draft, or is it ready for review? |
@doazen I need to re-review this myself, and see what more validation I can do. I hate to miss the release, but I won't be able to do that today. |
@cmnbroad No problem, this isn't particularly time-sensitive. Ping me once it's ready for review. |
@droazen I thought I had updated this months ago saying that I was finished validating, and that it was ready for review, but it appears that I didn't. But anyway its ready. |
…statements, update tests and example tool.
Codecov Report
@@ Coverage Diff @@
## master #7402 +/- ##
===============================================
+ Coverage 86.954% 86.956% +0.002%
- Complexity 36897 36910 +13
===============================================
Files 2214 2214
Lines 173540 173578 +38
Branches 18736 18736
===============================================
+ Hits 150900 150937 +37
- Misses 16037 16042 +5
+ Partials 6603 6599 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks google to me.
Fix for #7401. Draft mode for now until I do more verification.