Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix surprisingly harmless typo in Dockerfile #7806

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Apr 25, 2022

There's a dash missing in what should be the --include argument to a git lfs pull invocation in the Dockerfile that appears to have the net effect of git lfs pull doing nothing at all. This adds back the dash so the command does what it was intended to do, but I was a bit surprised the build doesn't seem to care if the git lfs pull actually pulls anything or not. 🤔

Before:

Screen Shot 2022-04-25 at 11 15 58 AM

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #7806 (ecf8dbc) into master (b6a28d1) will decrease coverage by 7.357%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #7806       +/-   ##
===============================================
- Coverage     86.941%   79.583%   -7.357%     
+ Complexity     36860     34813     -2047     
===============================================
  Files           2211      2211               
  Lines         173376    173376               
  Branches       18710     18710               
===============================================
- Hits          150734    137978    -12756     
- Misses         16055     28996    +12941     
+ Partials        6587      6402      -185     
Impacted Files Coverage Δ
...adinstitute/hellbender/utils/help/TestWDLTool.java 0.000% <0.000%> (-100.000%) ⬇️
...kers/filters/VariantFiltrationIntegrationTest.java 0.658% <0.000%> (-99.342%) ⬇️
...dorientation/CollectF1R2CountsIntegrationTest.java 0.714% <0.000%> (-99.286%) ⬇️
...s/variantutils/VariantsToTableIntegrationTest.java 0.862% <0.000%> (-99.138%) ⬇️
...der/tools/walkers/sv/SVClusterIntegrationTest.java 0.500% <0.000%> (-99.000%) ⬇️
.../walkers/bqsr/BaseRecalibratorIntegrationTest.java 1.031% <0.000%> (-98.969%) ⬇️
...tion/ReferenceBlockConcordanceIntegrationTest.java 0.840% <0.000%> (-98.599%) ⬇️
...tute/hellbender/tools/FlagStatIntegrationTest.java 1.724% <0.000%> (-98.276%) ⬇️
...on/FindBreakpointEvidenceSparkIntegrationTest.java 1.754% <0.000%> (-98.246%) ⬇️
...park/pipelines/CountReadsSparkIntegrationTest.java 1.786% <0.000%> (-98.214%) ⬇️
... and 190 more

@mcovarr mcovarr changed the title Fix typo that broke git lfs pull Fix surprisingly harmless typo in Dockerfile Apr 25, 2022
@mcovarr mcovarr marked this pull request as ready for review April 25, 2022 17:21
@mcovarr mcovarr requested a review from lbergelson April 25, 2022 18:35
@lbergelson
Copy link
Member

@mcovarr Huh. I'm surprised that didn't fail the docker build. I would have expected the command failing to abort it, but I guess that's not the case.

This step is not really necessary. If those files aren't checked out at build time gradle will do it for you, so that's why it didn't seem to cause any problems.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lbergelson lbergelson merged commit 234011e into master Apr 25, 2022
@lbergelson lbergelson deleted the fix_dockerfile_git_lfs_pull_typo branch April 25, 2022 21:11
mcovarr added a commit that referenced this pull request Apr 25, 2022
* this fixes a typo that caused one of our docker steps to be broken.  It was masked by the build process which retries the same step if it needs to.
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants