Don't require python to just instantiate tool classes. #8128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbergelson
requested changes
Dec 15, 2022
There was a problem hiding this comment.
@cmnbroad I would the initializers to onStartup with the pythonPackage check unless there's a reason not to that I'm missing.
| @@ -140,6 +139,9 @@ protected void onStartup() { | |||
|
|
|||
| @Override | |||
| protected Object doWork() { | |||
| // Start the Python executor. This does not actually start the Python process, but fails if python can't be located | |||
There was a problem hiding this comment.
It seems like this should be in onStartup.
| @@ -127,6 +126,9 @@ protected void onStartup() { | |||
|
|
|||
| @Override | |||
| protected Object doWork() { | |||
| // Start the Python executor. This does not actually start the Python process, but fails if python can't be located | |||
There was a problem hiding this comment.
I think this should probably go in onStartup
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8128 +/- ##
================================================
+ Coverage 46.436% 86.641% +40.205%
- Complexity 26473 38958 +12485
================================================
Files 2336 2336
Lines 182709 182731 +22
Branches 20060 20067 +7
================================================
+ Hits 84843 158320 +73477
+ Misses 91960 17367 -74593
- Partials 5906 7044 +1138
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CNN tools launch python immediately even when they're just instantiated, rather than waiting until the tool actually starts executing. This can cause some build tasks (gatkDoc, gatkWDLGen, etc.) to fail if python isn't available.