-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty input in TransferReadTags #8198
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8198 +/- ##
===============================================
- Coverage 86.658% 86.651% -0.007%
- Complexity 39024 39155 +131
===============================================
Files 2337 2346 +9
Lines 182961 183623 +662
Branches 20079 20148 +69
===============================================
+ Hits 158550 159111 +561
- Misses 17365 17449 +84
- Partials 7046 7063 +17
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test where 1 file has 0 and 1 file has x reads to see that it fails with UserException; add test where both have 0 reads to see that warning is raised and output has 0 reads.
@tmelman I have added tests, so this is ready for another round of review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TransferReadTags will throw an exception if the unaligned bam has no read. This pr will allow the unaligned bam to have 0 reads, as long as the aligned bam also has 0 reads, which will result in an output bam which is just a copy of the aligned bam, with 0 reads.