Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RWB Search Export [VS-909] #8311

Merged
merged 10 commits into from
May 17, 2023
Merged

RWB Search Export [VS-909] #8311

merged 10 commits into from
May 17, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented May 11, 2023

No description provided.

rsasch
rsasch approved these changes May 17, 2023
View reviewed changes
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a whole lotta bash, so 🤷🏻‍♀️ and 👍🏻

koncheto-broad
koncheto-broad approved these changes May 17, 2023
View reviewed changes
Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I vote for redoing it in Perl, but I accept that I have been overridden here.

@mcovarr mcovarr merged commit b64a252 into ah_var_store May 17, 2023
@mcovarr mcovarr deleted the vs_909_rwb_search_query branch May 17, 2023 20:03
mcovarr added a commit that referenced this pull request May 17, 2023
@mcovarr
RWB Search Export [VS-909] (#8311)
2e7b03a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koncheto-broad koncheto-broad koncheto-broad approved these changes

@rsasch rsasch rsasch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcovarr @rsasch @koncheto-broad