-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graph method for PDHMM event groups that unifies finding/merging and overlap/mutual exclusion #8366
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8366 +/- ##
===============================================
- Coverage 86.314% 86.293% -0.021%
- Complexity 39474 39480 +6
===============================================
Files 2358 2358
Lines 185234 185226 -8
Branches 20323 20339 +16
===============================================
- Hits 159882 159837 -45
- Misses 18196 18223 +27
- Partials 7156 7166 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat. It certainly reads better... the jury is still out on wether the graph overhead and the graph connectivity inspector is necessarily the most efficient approach here when there are a lot of events... I doubt this is going to be that severe cost however. I also think this is going to be much easier to extend for the jointdetection code than the current factoring which is good...
I would consider running a much larger section (like a chromosome) to inspect for mismatches with the old code... i'm not sure i'm convinced that the integration is sufficient to catch edge cases with this code
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Outdated
Show resolved
Hide resolved
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Outdated
Show resolved
Hide resolved
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Outdated
Show resolved
Hide resolved
.../hellbender/tools/walkers/haplotypecaller/PartiallyDeterminedHaplotypeComputationEngine.java
Outdated
Show resolved
Hide resolved
…overlap/mutual exclusion
d374080
to
62166d4
Compare
@jamesemery Ready for re-review. I ran this branch against master in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for double checking the outputs on a larger section. 👍
@jamesemery The fun begins. No change in output yet, but a non-trivial change in implementation.
Instead of making preliminary event groups according to overlap, then merging them according to mutually excluded events, this PR does it all in one step while automatically handling transitivity by treating as a matter of finding connected components of a graph whose vertices are events and whose edges are reasons (overlap and mutex) for events to be in the same event group.
All the failures are from WDL tests. I assume those are not related.