Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for breakend replacement alleles in SVCluster #8408

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

mwalker174
Copy link
Contributor

Implements allele collapsing for "breakend replacement" BND alleles, as described in section 5.4 of the VCFv4.2 spec.

Also:

  • Validates symbolic alt allele for non-BND SV classes when attempting to collapse multiple alt alleles.
  • Greatly improves unit test coverage for CanonicalSVCollapser.

Copy link
Contributor

@epiercehoffman epiercehoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Approved pending final checks on downstream impacts and the svtk behavior

final Allele refAllele = collapseRefAlleles(representative.getContigA(), start);
final List<Allele> altAlleles;
if (type == GATKSVVCFConstants.StructuralVariantAnnotationType.BND) {
altAlleles = Collections.singletonList(constructBndAllele(strandA, representative.getStrandB(), representative.getContigB(), end, refAllele));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
altAlleles = Collections.singletonList(constructBndAllele(strandA, representative.getStrandB(), representative.getContigB(), end, refAllele));
altAlleles = Collections.singletonList(constructBndAllele(strandA, strandB, representative.getContigB(), end, refAllele));

@mwalker174 mwalker174 merged commit d79823f into master Jul 12, 2023
@mwalker174 mwalker174 deleted the mw_collapse_bnd_alleles branch July 12, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants