-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenomicsDB on azure #8438
GenomicsDB on azure #8438
Conversation
I see I didn't respond here previously, but this branch has been working for me and is what I'm currently using. Would be great to get it merged along with #8470 |
0b5be67
to
8fd8e7f
Compare
Github actions tests reported job failures from actions build 6895762275
|
Github actions tests reported job failures from actions build 6896352136
|
e51318e
to
7b57c02
Compare
7b57c02
to
c6c875a
Compare
Github actions tests reported job failures from actions build 7143483544
|
c6c875a
to
5889662
Compare
Github actions tests reported job failures from actions build 7144734512
|
* GATK's lack of support for az:// uri means that although genomicsdb can natively read them, parts of the java code crash when they're passed through * Adding --avoid-nio and --header parameters these allow disabling all of the java codes interaction with the az:// links and simply pass them through to genomicsdb This disables some safeguards but allows operating on files in azure * Move GenomicsDB version to released 1.5.1 for azure improved support * There are no direct tests on azure since we do not yet have any infrastructure to generate the necessary tokens --------- Co-authored-by: Nalini Ganapati <[email protected]> Co-authored-by: Nalini Ganapati <[email protected]>
5889662
to
de45517
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
adding two new parameters which work together to allow passing through files from azure too genomicsDB
--header <vcf>
which lets you specify a vcf file to use the header from as your merged header. Do not mess this up or you will likely be doomed.--avoid-nio
which disables GATK sanity checks that involve reading the files since this would require opening them on azure.This needs tests but I wanted to put it here for @meganshand to try.