-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make M2 haplotype and clustered events filters smarter about germline events #8717
Conversation
Github actions tests reported job failures from actions build 8172680846
|
Github actions tests reported job failures from actions build 8181065857
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8717 +/- ##
===============================================
- Coverage 86.407% 83.640% -2.767%
+ Complexity 39882 38213 -1669
===============================================
Files 2371 2371
Lines 187596 187624 +28
Branches 20532 20537 +5
===============================================
- Hits 162096 156928 -5168
- Misses 18272 23475 +5203
+ Partials 7228 7221 -7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How hard would it be to put in a regression test where you do something similar to #7391 and compare with and without --genotype-germline-sites? There's not a lot of coverage for that arg as-is. And I'm a little concerned that while the ECNT annotation changed in the SW test, there were no filtering changes in order tests.
src/main/java/org/broadinstitute/hellbender/tools/walkers/mutect/SomaticGenotypingEngine.java
Show resolved
Hide resolved
src/test/java/org/broadinstitute/hellbender/tools/walkers/mutect/Mutect2IntegrationTest.java
Show resolved
Hide resolved
...va/org/broadinstitute/hellbender/tools/walkers/mutect/filtering/FilteredHaplotypeFilter.java
Outdated
Show resolved
Hide resolved
Added a regression test with two good variants that this PR rescues from being false negatives. Also made the sensitivity thresholds in the other integration tests higher because even without |
Github actions tests reported job failures from actions build 8349590850
|
I saw your "whoops" commit -- I have actually merged commits that turn off tests. James is trying to figure out if we can have codecov check the absolute number of tests since that should almost never go down. He claims you can run select tests from the data provider with IntelliJ, but it seems... cumbersome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new test! The sensitivity threshold is a good find too
Github actions tests reported job failures from actions build 8354454301
|
Github actions tests reported job failures from actions build 8384399332
|
Closes #7391