Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize test results directory between normal/docker tests #8718

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

lbergelson
Copy link
Member

  • Changing test results directory for the docker tests to match the test results directory from the non docker test.
  • Awkward handling of this seems to have been resulting in different test output paths and causing the reporting bot to sometimes fail to report the correct file location

@lbergelson
Copy link
Member Author

I need to run this with both passing AND failing tests to make sure paths are all correct.

@droazen droazen self-assigned this Mar 6, 2024
@droazen droazen self-requested a review March 6, 2024 18:44
Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me....merge if it fixes the issue

@gatk-bot
Copy link

gatk-bot commented Mar 6, 2024

Github actions tests reported job failures from actions build 8176966441
Failures in the following jobs:

Test Type JDK Job ID Logs
integration 17.0.6+10 8176966441.11 logs
integration 17.0.6+10 8176966441.0 logs

@jamesemery
Copy link
Collaborator

The logs button from the gatk bot still seems to not be working here

@gatk-bot
Copy link

gatk-bot commented Mar 6, 2024

Github actions tests reported job failures from actions build 8177733856
Failures in the following jobs:

Test Type JDK Job ID Logs
integration 17.0.6+10 8177733856.11 logs
integration 17.0.6+10 8177733856.0 logs

@lbergelson lbergelson marked this pull request as ready for review March 6, 2024 22:52
@lbergelson
Copy link
Member Author

Seems like it's working for failing tests both docker and normal now.

@droazen droazen merged commit a2ebb37 into master Mar 7, 2024
20 checks passed
@droazen droazen deleted the lb_fix_test_path branch March 7, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants