Update the large CRAM files to v3.0. #8832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Github actions tests reported job failures from actions build 9085418098
|
|
Github actions tests reported job failures from actions build 9085946968
|
|
Github actions tests reported job failures from actions build 9368869663
|
lbergelson
reviewed
Jul 11, 2024
| final SAMRecordIterator sourceIterator = sourceReader.iterator(); | ||
| final SAMRecordIterator targetIterator = copyReader.getIterator(); | ||
|
|
||
| while (sourceIterator.hasNext() && targetIterator.hasNext()) { |
There was a problem hiding this comment.
You're missing out on the exciting method BaseTest.assertCondition()
lbergelson
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CRAM v3.0 version of the existing (CRAM v2.1) test file
CEUTrio.HiSeq.WGS.b37.NA12878.20.21.cramin git-lfs and in the cloud test resources bucket. In both cases, the old files are left intact for now. Roundtrip tests using both the old and new versions of the local file are also added.At some point, the old files can be removed, but when we do so, old branches will need to be rebased on this code or the cloud tests will fail, since the cloud test in this PR uses the new file name (that includes the CRAM version in the name).