Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS-1485 - Optionally call CollectVariantCallingMetrics from ExtractVcfs #8968

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

gbggrant
Copy link
Collaborator

Added ability to call gatk tools to collect variant calling metrics.
It is optional, and defaulted to not collect.

Passing Extract run with metrics collected here.
Passing Extract run where we don't (default) collect metrics here.
Passing Integration test here

Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine I'm just worried about scary costs 😱

Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbggrant gbggrant merged commit ae8b601 into ah_var_store Sep 9, 2024
10 of 16 checks passed
@gbggrant gbggrant deleted the gg_AddVariantCallingMetrics branch September 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants