[JN-1467] doc request admin ux #1203
Conversation
| export const getSurveyContentTemplate = (survey: Survey, isScreener: boolean): string => { | ||
| if (survey.surveyType === 'OUTREACH' && !isScreener) { | ||
| return OUTREACH_SCREENER_TEMPLATE(survey) | ||
| } | ||
| if (survey.surveyType === 'DOCUMENT_REQUEST') { | ||
| return DOC_REQUEST_TEMPLATE(survey) | ||
| } | ||
| return DEFAULT_TEMPLATE | ||
| } |
There was a problem hiding this comment.
I wanted to formalize the concept of a survey template without pushing it to the backend. I'm not super happy with isScreener but it's a start. Probably right move would be to make a SurveyTemplateOptions with survey type, out reach type, blurb etc. so that we can fill these templates out more intelligently. I'll investigate on my later PR that will make document request creation streamlined.
| private void validateAnswer(Answer answer) { | ||
| answer.inferTypeIfMissing(); | ||
| if (answer.getFormat() == null) { | ||
| answer.setFormat(AnswerFormat.NONE); | ||
| } | ||
|
|
||
| if (answer.getFormat().equals(AnswerFormat.FILE_NAME)) { | ||
| System.out.println(answer.getEnrolleeId()); | ||
| System.out.println(answer.getStringValue()); | ||
| participantFileService.findByEnrolleeIdAndFileName(answer.getEnrolleeId(), answer.getStringValue()) | ||
| .orElseThrow(() -> new IllegalArgumentException("File not found for answer")); | ||
| } | ||
| } |
There was a problem hiding this comment.
Since we have the new "format" column, this method will enforce the format. For now it's just file name, but if we get, e.g., date or regex formats, then this will also ensure that the string actually conforms to that format.
| @@ -31,6 +31,7 @@ public class Answer extends BaseEntity { | |||
| private int surveyVersion; | |||
| private String viewedLanguage; | |||
| private AnswerType answerType; | |||
| private AnswerFormat format; | |||
There was a problem hiding this comment.
After much going back and forth, I think I've finally settled into being comfortable adding participant files as regular survey response answers with the caveat that we have a new "format" column that dictates how to interpret the data that's present (separate from answer type, which tells you the literal type, e.g. string)
As such, the newly created table ParticipantFileSurveyResponse had an unfortuantely lifespan of less than a week 😢
| package bio.terra.pearl.core.model.survey; | ||
|
|
||
| public enum AnswerFormat { | ||
| NONE, |
There was a problem hiding this comment.
I debated TEXT as the default but that might not always be true (e.g., if it's in the number column). So I felt NONE was more appropriate for a standard "unformatted" answer.
|
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
Allows creating document requests, viewing the uploaded files, and downloading them.
Next up will be the participant UX. For now, creating and editing a document request works like a normal survey. After refining the participant experience, I'll go back and make the admin creation of a document request more streamlined.
TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)