-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ml4h install: vtk module is pinned to a version not supported in py3.8 #450
Comments
Thanks for reporting the issue! I cannot reproduce it on Moving to vtk>=9.0.0 would probably be fine if that unblocks you. We can fix eventual compatibility issues in the mesh generation code at a later stage. |
Oh, interesting. I'm using |
Understood! I guess it's up to you then. If having vtk==9.0.0 (and Python 3.8) makes it easier for you, please feel free to go ahead with a PR and we can deal with eventual incompatibilities later on. |
Thanks. I think I'll hold off on the PR for now, as I can work around the issue by instead using py 3.7, and I'd hate to break anyone unexpectedly. But we can leave the issue up for tracking. |
I tried doing an ml4h install as follows:
pip install git+https://github.com/broadinstitute/ml4h.git
I got the following error. It looks like the vtk module is pinned to a too-old version that has since been removed. I am happy to put in a PR to fix this, if someone will let me know what version it should be changed to.
cc @deflaux as fyi
The text was updated successfully, but these errors were encountered: