Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Barclay dependency. #1053

Merged
merged 1 commit into from
Jan 6, 2018
Merged

Upgrade Barclay dependency. #1053

merged 1 commit into from
Jan 6, 2018

Conversation

cmnbroad
Copy link
Contributor

@cmnbroad cmnbroad commented Jan 4, 2018

Description

We plan to release a new Barclay version sometime today, and then will request a Picard release containing that, plus #1043 and as many doc update PRs as possible, to package with the GATK release.

Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • [x ] All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

@coveralls
Copy link

coveralls commented Jan 4, 2018

Coverage Status

Coverage remained the same at 77.647% when pulling d66ddb8 on cn_upgrade_barclay into a86b2fc on master.

@tbl3rd tbl3rd self-assigned this Jan 4, 2018
Copy link
Contributor

@tbl3rd tbl3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM FWIW

@coveralls
Copy link

coveralls commented Jan 6, 2018

Coverage Status

Coverage remained the same at 77.654% when pulling c78ea21 on cn_upgrade_barclay into b9b8777 on master.

@coveralls
Copy link

coveralls commented Jan 6, 2018

Coverage Status

Coverage remained the same at 77.706% when pulling c1b60ab on cn_upgrade_barclay into e0e659f on master.

@cmnbroad cmnbroad changed the title Upgrade Barclay dependency. DO NOT MERGE. Upgrade Barclay dependency. Jan 6, 2018
@sooheelee
Copy link
Contributor

Needs review by @vdauwera or @yfarjoun please.

@cmnbroad cmnbroad merged commit 42b7c7b into master Jan 6, 2018
@cmnbroad cmnbroad deleted the cn_upgrade_barclay branch January 6, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants