Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure adding additional trees does not affect include/exclude results. #147

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jun 17, 2021

In a7ed4fa we added support for passing additional trees to the constructor (to ensure that they can be ready to read in subclasses), but we didn't ensure that all internal usage of this.input was limited to the first tree passed. This didn't matter much for the simple symlink srcDir <-> destDir situation, but as soon as you use custom include/exclude globs (and we therefore have to walk all the files) we would trigger errors.

This fixes that oversight by ensuring that all usage of this.input is scoped to this.input.at(0), and adds a previously failing test.

In a7ed4fa we added support for passing
additional trees to the constructor (to ensure that they can be ready to
read in subclasses), but we didn't ensure that all internal usage of
`this.input` was limited to the first tree passed. This didn't matter
much for the simple symlink srcDir <-> destDir situation, but as soon as
you use custom `include`/`exclude` globs (and we therefore have to walk
all the files) we would trigger errors.

This fixes that oversight by ensuring that all usage of `this.input` is
scoped to `this.input.at(0)`, and adds a previously failing test.
@rwjblue rwjblue added the bug label Jun 17, 2021
@rwjblue rwjblue merged commit dcae5e2 into master Jun 17, 2021
@rwjblue rwjblue deleted the ensure-additional-trees-dont-leak branch June 17, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant