Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color option is missing #21

Open
ThangCZ opened this issue May 29, 2018 · 6 comments
Open

Color option is missing #21

ThangCZ opened this issue May 29, 2018 · 6 comments

Comments

@ThangCZ
Copy link
Contributor

ThangCZ commented May 29, 2018

The -c, -color option is missing. It's an essential part of iproute2. We should definitely support it!

@naggie
Copy link

naggie commented May 30, 2018

This would be great. At least at first, the -c and -color options could be ignored such that aliases don't break.

@brona
Copy link
Owner

brona commented Jun 4, 2018

Ignoring shouldn't be a problem to maintain cli compatibility. Will be likely in next release.
Full feature implementation however seems a bit tricky, I will have to review the underlying commands.

@brona
Copy link
Owner

brona commented Aug 1, 2024

Color option is now being ignored for script compatibility, keeping the FR open to implement it for real.

@naggie
Copy link

naggie commented Aug 1, 2024

Thanks @brona !

@silverwind
Copy link

silverwind commented Aug 19, 2024

Color option is now being ignored for script compatibility, keeping the FR open to implement it for real.

Are you sure? I'm still seeing an error with latest version:

$ ip -c a
Option "-c" is unknown, try "ip help".
$ ip -V
iproute2mac, v1.5.2

brona added a commit that referenced this issue Aug 19, 2024
@brona
Copy link
Owner

brona commented Aug 19, 2024

Color option is now being ignored for script compatibility, keeping the FR open to implement it for real.

Are you sure? I'm still seeing an error with latest version:

$ ip -c a
Option "-c" is unknown, try "ip help".
$ ip -V
iproute2mac, v1.5.2

Thank you for the report, fixied in v1.5.3. -color=never was already being parsed correctly (and ignored), however there was a bug for -c. You can track the release to Homebrew on Homebrew/homebrew-core#181685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants