Babel: Toolchain support via :toolchain
#279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows one to specify `'(foo . "path/to/dependency")` so that Cargo will look locally for the dependency, instead of pulling from crates.io. This is very useful for testing local Rust code in Org snippets.
This allows the user to use the Beta or Nightly toolchains in snippets.
fosskers
changed the title
:nightly:toolchain
|
I ran the tests manually(there seem to be some issues with cask again). Sorry for the delay and thanks for the contribution! |
brotzeit
approved these changes
Oct 12, 2021
lroolle
reviewed
Sep 13, 2022
Comment on lines
-57
to
+59
| (params '("cargo" "build" "--quiet")) | ||
| (toolchain (cond ((eq toolchain-kw 'nightly) "+nightly") | ||
| ((eq toolchain-kw 'beta) "+beta") | ||
| (t "+stable"))) |
There was a problem hiding this comment.
This only allows nightly/beta/stable channels by keyword.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah I see the issue. We could expand the accepted format of toolchain-kw to allow for more free-form strings, and pass those as-is (or parse them?) down to the cargo line.
There was a problem hiding this comment.
That should do the trick.
|
how to disable this? i didn't install rust tools with rustup; i use my systems' package manager. setting |
|
That use-case never occurred to me so I wasn't aware that |
yuuyins
added a commit
to yuuyins/rustic
that referenced
this pull request
Feb 13, 2023
When the user installs Rust tools using a method other than rustup, e.g. using an operating system's package manager, cargo generally has no support for toolchain specification. In such case, the user can then `nil', or `""', so that the rescpective functions in `rustic-babel' will remove the toolchain from params, that is only toolchain has a valid value it uses toolchain. See also: brotzeit#279 (comment)
yuuyins
added a commit
to yuuyins/rustic
that referenced
this pull request
Feb 13, 2023
When the user installs Rust tools using a method other than rustup, e.g. using an operating system's package manager, cargo generally has no support for toolchain specification. In such case, the user can then `nil', or `""', so that the rescpective functions in `rustic-babel' will remove the toolchain from params, that is only toolchain has a valid value it uses toolchain. See also: brotzeit#279 (comment)
yuuyins
added a commit
to yuuyins/rustic
that referenced
this pull request
Apr 22, 2023
When the user installs Rust tools using a method other than rustup, e.g. using an operating system's package manager, cargo generally has no support for toolchain specification. In such case, the user can then `nil', or `""', so that the respective functions in `rustic-babel' will remove the toolchain from params, i.e. only toolchain has a valid value if Cargo has toolchain support. See also: brotzeit#279 (comment) Fixes brotzeit#498 introduced in 80d05c4 Co-authored-by: Sibi Prabakaran <[email protected]>
yuuyins
added a commit
to yuuyins/rustic
that referenced
this pull request
May 22, 2023
When the user installs Rust tools using a method other than rustup, e.g. using an operating system's package manager, cargo generally has no support for toolchain specification. In such case, the user can then `nil', or `""', so that the respective functions in `rustic-babel' will remove the toolchain from params, i.e. only toolchain has a valid value if Cargo has toolchain support. See also: brotzeit#279 (comment) Fixes brotzeit#498 introduced in 80d05c4 Co-authored-by: Sibi Prabakaran <[email protected]>
CeleritasCelery
pushed a commit
to emacs-rustic/rustic
that referenced
this pull request
May 17, 2024
When the user installs Rust tools using a method other than rustup, e.g. using an operating system's package manager, cargo generally has no support for toolchain specification. In such case, the user can then `nil', or `""', so that the respective functions in `rustic-babel' will remove the toolchain from params, i.e. only toolchain has a valid value if Cargo has toolchain support. See also: brotzeit/rustic#279 (comment) Fixes #498 introduced in 80d05c4 Co-authored-by: Sibi Prabakaran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to specify the toolchain via a new
:toolchainkeyword when writing Org snippets.Note: This PR was built off #278, so that should be merged first.
Closes #277