Loosen semver for inherits #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redonkulus
approved these changes
Jun 24, 2019
|
@goto-bus-stop alternatively we could just pin the version at 2.0.4 if that's preferred. Let me know and I can update this PR to reflect that. |
goto-bus-stop
approved these changes
Jun 27, 2019
There was a problem hiding this comment.
Thanks! this seems OK for now, but perhaps util.inherits should use a different package, if inherits is not actually strictly a util.inherits polyfill. In Node.js, not passing in a superclass deliberately throws an error.
If you rely on this behaviour make sure to only access it through require('inherits'), because util.inherits is not supposed to support it and it might change in a later version!
|
@goto-bus-stop anything else you need from my end to get this merged and published? |
This was referenced Feb 4, 2020
This was referenced Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@goto-bus-stop https://github.com/isaacs/inherits has been updated with a patch fix and while some of our client side packages have picked up this newer version, this package is locked to the older version.
This ends up bloating our client side js since we have duplicate versions of inherits if any package specifies
^2.0.4( although you could make the case that they could loosen their semver to accept ^2.0.3 ).isaacs/inherits@v2.0.3...v2.0.4
Can we loosen the semver requirement on inherits so that we don't have this issue? Thanks!