Adds support for "paths" being a function #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Nov 16, 2018
ljharb
force-pushed
the
paths=fn
branch
2 times, most recently
from
15acb75
to
d5dc919
Compare
ljharb
approved these changes
Nov 22, 2018
|
@ljharb By any chance, do you have an ETA for the next release? |
|
@arcanis i've got a branch ready, but there's two bugfixes I'm trying to get fixed first. Hopefully within the next week! |
ljharb
added a commit
that referenced
this pull request
Dec 17, 2018
- [New] `async`/`sync`/`node-modules-paths`: Adds support for “paths” being a function (#172, #173) - [New] Implements a "normalize-options" pseudo-hook (#174) - [Fix] `sync`/`async`: fix `preserveSymlinks` option (#177) - [Fix] `sync`/`async`: when package.json `main` is not a string, throw an error (#178) - [Deps] update `path-parse` - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `object-keys`, `safe-publish-latest`, `tape` - [Tests] up to `node` `v11.4`, `v10.14`, `v8.14`, `v6.15` - [Tests] better failure messages
6 tasks
This was referenced Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of #170.
This PR adds support for the
pathsoption being a function. This allows to dynamically compute the lookup paths based on the path being requested and the issuer making the request.