Fixes isCore async check #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
pushed a commit
that referenced
this pull request
Jan 6, 2020
ljharb
added a commit
that referenced
this pull request
Jan 7, 2020
ljharb
added a commit
that referenced
this pull request
Jan 7, 2020
v1.14.2 - [Fix] `sync`/`async`: Fixes isCore check (#206)
This was referenced Jan 15, 2020
ljharb
added a commit
that referenced
this pull request
Jan 22, 2020
Changes since v2.0.0-next.0: - [Breaking] add ESM wrapper to "exports"; change paths to match - [Breaking] add "exports" to `package.json` Including all changes in v1.14.2 and v1.15.0: - [New] `sync`'/`async`: Implement `packageIterator` (#205) - [Fix] `sync`/`async`: Fixes isCore check (#206) - [Refactor] `sync`: add function name - [Refactor] remove useless `exports` assignment - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `tape`
This was referenced Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a slight difference between the sync and async codepaths in that the
isCoreasync check is done in theloadNodeModulescallback rather than right before the call.I'm not sure how to test it though since it has the same behaviour except that packageIterator (from #205) won't be called with core packages.