Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Safari 5.0.x poll from interfering with pushState until hash change propagates #150

Closed
wants to merge 3 commits into from

Commits on Jan 19, 2012

  1. Fix safari poll timing bug during pushState

    If a pushState has just occurred and the Safari poller checks to see
    if the hash has changed before the hashchange propagates, then it
    sees the new state as being different from the actual state, thus
    triggering a pushState. This patch sets a flag (waitForPropagation)
    which is cleared by an interval after the hashchange finally
    propagates.
    
    The question.. what happens if a second pushState occurs before
    the hashchange propagates?
    Eric O'Connell committed Jan 19, 2012
    Configuration menu
    Copy the full SHA
    45f3034 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2012

  1. Configuration menu
    Copy the full SHA
    0145f47 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2012

  1. fix storeState and getIdByUrl for Safari 5.0.x

    History.storeState was only updating the urlToId mapping when new states
    were stored during the session, and then updating the idToState and
    stateToId mappings on unload, so when the safariStatePoll attempted
    to check if the current state was the lastSavedState, that function's
    dependency on extractState would fail as it was using the idToState
    mapping.
    Eric O'Connell committed Jan 21, 2012
    Configuration menu
    Copy the full SHA
    caec51b View commit details
    Browse the repository at this point in the history